[nix] replace streamLayeredImage to buildImage #612
Merged
+40
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we are using qemu now. How about providing multiple arch(aarch64,x86,riscv) in our release? |
Avimitin
force-pushed
the
hotfix/release
branch
2 times, most recently
from
5f2176a
to
99087d3
Compare
sequencer
reviewed
May 27, 2024
.github/workflows/release.yml
Outdated
| @@ -2,6 +2,7 @@ name: Build Docker Image | |||
|
|
|||
| # Release on any git tag | |||
| on: | |||
| pull_request: | |||
There was a problem hiding this comment.
It is on tagging, pull_request is for testing only.
Avimitin
force-pushed
the
hotfix/release
branch
2 times, most recently
from
f7432b1
to
d5afc56
Compare
Proot have too many bugs to be fixed, it is better to use qemu to build the docker image. Signed-off-by: Avimitin <[email protected]>
Signed-off-by: Avimitin <[email protected]>
sequencer
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proot have too many bugs to be fixed, it is better to use qemu to build the docker image.